Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed DrawingSurfaceBackgroundGrid in Game.xaml #2220

Closed
wants to merge 1 commit into from
Closed

Fixed DrawingSurfaceBackgroundGrid in Game.xaml #2220

wants to merge 1 commit into from

Conversation

RTLShadow
Copy link

credit to nZeus/MonoGame, fixes issue with functions not being called in WP8 builds.

credit to nZeus/MonoGame, fixes issue with functions not being called in WP8 builds.
@mgbot
Copy link
Member

mgbot commented Feb 8, 2014

Can one of the admins verify this patch?

1 similar comment
@mgbot
Copy link
Member

mgbot commented Feb 8, 2014

Can one of the admins verify this patch?

@KonajuGames
Copy link
Contributor

@mgbot test

@mgbot
Copy link
Member

mgbot commented Feb 8, 2014

Test PASSed.
Refer to this link for build results: http://build.monogame.net/job/PullRequestTester/571/

@Nezz
Copy link
Member

Nezz commented Feb 9, 2014

Where is your DrawingSurfaceBackgroundGrid? It should be set using this line:
UIElement drawingSurface = page.Content as DrawingSurfaceBackgroundGrid;

@tomspilman
Copy link
Member

@Nezz - Are you saying this shouldn't be merged?

@Nezz
Copy link
Member

Nezz commented Feb 11, 2014

Yes, it shouldn't be merged unless @RTLShadow can explain where he put his DrawingSurfaceBackgroundGrid and why :)

@RTLShadow
Copy link
Author

@Nezz I was unaware that was needed- I can try it. Here is the issue it fixed (and the where i got the code from): #2081

@tomspilman
Copy link
Member

@Nezz - Are you happy with this now?

@Nezz
Copy link
Member

Nezz commented Apr 25, 2014

I still don't understand why the DrawingSurfaceBackgroundGrid is a child element and not the root.

From http://blogs.windows.com/windows_phone/b/wpdev/archive/2012/11/05/windows-phone-8-developer-platform-highlights.aspx:

DrawingSurfaceBackgroundGrid is a very special element that must always be the root element of a page and allows developers to render directly to the background from Direct3D using C++.

@tomspilman
Copy link
Member

Ok... gonna close this. @RTLShadow can resubmit if he can answer your questions about it.

@tomspilman tomspilman closed this Apr 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants